TheGameCreators / GameGuruRepo

The GameGuru Repository For Community Collaboration
http://www.game-guru.com
139 stars 56 forks source link

Group scaling bug #1022

Open synchromesh62 opened 3 years ago

synchromesh62 commented 3 years ago

Grouped items do not scale at the same rate .. Not the barrel moves from its position.

https://youtu.be/eISS4liWHQ8

System Specs: Operating System: Windows 10 Home 64-bit (10.0, Build 19042) (19041.vb_release.191206-1406) Language: English (Regional Setting: English) System Model: MS-7C02 Processor: AMD Ryzen 5 2600X Six-Core Processor (12 CPUs), ~3.6GHz Memory: 16384MB RAM Windows Dir: C:\Windows DirectX Version: DirectX 12 Card name: Radeon RX 580 Series Dedicated Memory: 8171 MB Current Mode: 1920 x 1080 (32 bit) (59Hz)

plemsoft commented 3 years ago

@LeeBamberTGC Im not sure how to solve this, the more i think about it the more my head hurt :) The video show a simple example , but we are scaling depending on each objects pivot, so if the barrel in the video had its pivot at the top and we scaled it would float in the air. So somehow we also need to scale the position of the object, but this need to be calculated based on each object different pivot point.

Also if you made a copy of the objects in the video, and placed/rotated them to form a "room" the 4 sections would move away from each other, so some kind of fixed pivot to use for scaling/position all of the objects would be needed. So when scaling down, it should move/scale each object toward the fixed pivot point and at the same time make sure the objects stay on the ground ?

Perhaps @AmenMoses has some clever math for this kind of thing :)

LeeBamberTGC commented 3 years ago

@plemsoft You can assign this one to me. Best to rattle through the low hanging fruit issues you have, and those you think you can fix quickly. The more 'complex' stuff like this one would benefit from discussion internally to decide 'exactly' what should happen.

AmenMoses commented 3 years ago

If implemented the way I originally suggested then each child object should be positioned relative to the origin point of the parent object, so you should have x,y,z offsets stored for each object in the group.

As the parent object is scaled it should be a simple case of scaling the offsets by the same amount I would have thought.

On 6 May 2021, at 09:34, Lee Bamber @.***> wrote:

@plemsoft https://github.com/plemsoft You can assign this one to me. Best to rattle through the low hanging fruit issues you have, and those you think you can fix quickly. The more 'complex' stuff like this one would benefit from discussion internally to decide 'exactly' what should happen.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TheGameCreators/GameGuruRepo/issues/1022#issuecomment-833341452, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIQN3MXVYWGBGLXZWUXBAZLTMJIARANCNFSM4ZOWYBJQ.

LeeBamberTGC commented 2 years ago

NOTE: I see argument for having both functionalities, one that scales in place, and one that scales relative offset positions too, a tick box in the area around the scale slider.