TheGameCreators / GameGuruRepo

The GameGuru Repository For Community Collaboration
http://www.game-guru.com
137 stars 56 forks source link

Camera Override no longer working the way it should #2777

Closed AmenMoses closed 2 years ago

AmenMoses commented 2 years ago

SetCameraOverride( v ) function is supposed to override the camera.

Cine|Guru relies on this functioning properly but now even after the function has been called, i.e. by SetCameraOverride( 3 ), the player moving the mouse will affect the camera when it should be under script control.

LeeBamberTGC commented 2 years ago

@AmenMoses Added new behavior called FreezePlayer in markers script folder, and looks like SetCameraOverride(3) and SetCameraOverride(0) work fine, freezing all camera position and rotation until freed up. Check out latest EXP build later on.

AmenMoses commented 2 years ago

By later on you mean when exactly. Latest experimental build is still not working.

SetCameraOverride(3) should put the camera control in the hands of Lua not freeze it.

But atm when the cinematic is playing moving the mouse is trying to move the camera when it shouldn't.

LeeBamberTGC commented 2 years ago

@AmenMoses If you have time, can you modify the FreezePlayer script to show the functionality you mean and specifically show it not working? I can then wort it out for next weeks release :)

AmenMoses commented 2 years ago

Hmm, your script works but Cine|Guru doesn't even though they are both calling SetCameraOverride(3).

So this means that some other functions being called by Cine|Guru must be overriding the override so-to speak.

Functions used include: SetCameraPanelFOV, SetCameraPosition, SetCameraAngle, SetFreezePosition & TransportToFreezePositionOnly.

(and some sprite commands but I doubt they are involved in anyway)

Could any of those be the culprit?

LeeBamberTGC commented 2 years ago

@AmenMoses I did some work with those commands for the Zombie 'brain eating' sequence, so yes there could be a tweak here and there that breaks old logic. Are you thinking of bringing Cine|Guru to MAX, that would be awesome!!

AmenMoses commented 2 years ago

I am attempting to do just that but hitting some issues, this change in camera override behaviour just being the first!

AmenMoses commented 2 years ago

As you can imagine the main camera control script for Cine|Guru is rather large and very complex.

I'll try to see if I can comment out those functions one by one and see if I can figure out the culprit.

AmenMoses commented 2 years ago

It's SetCameraAngle that is the culprit I believe. At least when I comment out the call to it the mouse no longer rotates the camera so I assume it must be overriding the camera override in some way.

AmenMoses commented 2 years ago

Aha, it's working now. I had a conflicting script hiding in my test level.