TheGameCreators / GameGuruRepo

The GameGuru Repository For Community Collaboration
http://www.game-guru.com
137 stars 56 forks source link

CineGuru Issues - Zones moving and changing dimensions on level save #4718

Closed davetgc closed 1 year ago

davetgc commented 1 year ago

Trigger zones are moving position and changing size and shape when a level is saved. This seems worse if the zone boundaries have been previously adjusted.

It becomes worse if several zones are placed.

AvengingEagle commented 1 year ago

Can confirm I'm experiencing this too. They seem to like moving to the same location as other zones within the level. As seen here: https://youtu.be/lbEYz5T93Ok?t=388

LeeBamberTGC commented 1 year ago

@AvengingEagle Thanks for the video, great to see CineGuru MAX progress!! Would like to help prioritise the MAX bugs that might get in your way to completion. I did a quick zone creation and movement test, but as you can imagine I was not able to reproduce the intermittency of the zone shift issue: image

Maybe you can send the level shown in the video as I suspect if the zone data is corrupt or cross linked in some way I can view this at the back end and see how the data might have got tangled and work out what is responsible. Feel free to reference other issues in this relating to CineGuru MAX core obstacles!

LeeBamberTGC commented 1 year ago

@davetgc Possible fix for next EXP build. There was an issue related to corrupt object groups being saved with a level, and then on reloading affecting other entity placement activity on the incorrect assumption some entities related to others and would move them too. Next EXP build detects these corrupt groups and deletes them from the level (back up your levels at all times as this is a new fix and is a destructive act)

AvengingEagle commented 1 year ago

Have I understood this correctly? The new EXP build will simply delete corrupt object groups, so stuff will potentially start going missing in our levels, rather than not corrupting in the first place?

LeeBamberTGC commented 1 year ago

@AvengingEagle I would not put it past me :) Alas no, any objects you place down will remain in the level just fine, it's just that any internal group data that is associated with objects that simply do not exist are deleted from the level, so the next time you save those groups are not associated with dead entities (and by extension do not mess with existing entities that have since been repurposed within the level, thus avoiding the issue yous saw with zones).

As to the original corruption, that still needs to be reproduced, if it still exists. I did a lot of work on Smart Objects around the V1 release and that fixed a lot of nasties around group data and the like, so it may be fixed and older levels are just carrying around some old corruptions. If you find any group data issues in the meantime, please do post here.

davetgc commented 1 year ago

I'm still seeing zones changing shape, but they don't appear to be moving anymore.

synchromesh62 commented 1 year ago

Could they also be made to stay to the surface ? That would probably help deformations. We don't need to lift the nodes up in the air any longer like we did in classic or fpsc.

davetgc commented 1 year ago

I've actually noticed that they sometimes rise up from their original position. For awhile I thought the hurt script had stopped working, but it seemed the zone had risen up, I only discovered this when I pressed jump in the zone and received damage.

On Fri, Jun 23, 2023 at 3:38 PM synchromesh62 @.***> wrote:

Could they also be made to stay to the ground ? That would probably help deformations. We don't need to lift the nodes up in the air any longer like we did in classic or fpsc.

— Reply to this email directly, view it on GitHub https://github.com/TheGameCreators/GameGuruRepo/issues/4718#issuecomment-1604299595, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXZOFYPRSV5IIIXTQWKPGQTXMWL5LANCNFSM6AAAAAAZKBSTGA . You are receiving this because you modified the open/close state.Message ID: @.***>

LeeBamberTGC commented 1 year ago

@davetgc Can you attach a small FPM level and a step by step on how I can see the zone shapes moving? So far, all the zones I have placed down stay put and I have not seen them change shape on me :)

davetgc commented 1 year ago

@LeeBamberTGC - I will try, but it doesn't seem to be happening in small levels, and is happening less than it did in larger levels. If I can replicate in a default media small level I'll update this.

LeeBamberTGC commented 1 year ago

@davetgc No worries, we can close this for now and re-open/re-link if this can be reproduced reliably. Even small movements in the zone should not affect most users, but if this can be pinned down, we will know more!