TheGameCreators / GameGuruRepo

The GameGuru Repository For Community Collaboration
http://www.game-guru.com
137 stars 56 forks source link

GGCLASSIC Bug - Specular camera setting doesn't work #5686

Open Ghost-l0l opened 3 weeks ago

Ghost-l0l commented 3 weeks ago

In Files/effectbank/reloaded there is the settings.fx file that lets us change some options and shader properities; I used it to modify many things, but it seems that the specular camera settings just don't work at all. Doesn't matter what values I try, it doesn't change anything. And I know what it should look like, because it worked years ago on previous updates.

If that's any helpful I can upload an older shader (apbr_core.fx from 2018) that has that specular camera working)

image

synchromesh62 commented 3 weeks ago

Didn't you have to update the blob files \ refresh the shader after you edited them ? Something like forceloadtestgameshaders = 2 in setup.ini before running your level in the editor. Or am i way off what your referring to.

Ghost-l0l commented 2 weeks ago

Yes yes, every time after you make any changes in settings.fx you must set forceloadtestgameshaders = 1 to reload all shaders, but this specular thing really doesn't work, I was changing many things in settings.fx and this is the only one that doesn't work.

LeeBamberTGC commented 3 days ago

@Ghost-l0l Please do send the apbr_core.fx from 2018 and I will do a WINDIFF. From the way the two defines are commented out, I am guessing this code was superceded with something else a long time ago. I will change to a feature request and find out what these defines do differently than the present handling of specular in apbr_core.fx

Ghost-l0l commented 3 days ago

@LeeBamberTGC apbr_core.zip That's the apbr_core.fx I was talking about;

I also packed in zip all shaders from reloaded folder, so you can see all changes I did in settings.fx too: reloaded.zip

Thank you for answering! :)

Ghost-l0l commented 3 days ago

@LeeBamberTGC I would also like to ask to look at this one issue that I reported few weeks ago, but it wasn't tagged in any way, so very possibly went under the radar; I think I already narrowed down where the problem is: https://github.com/TheGameCreators/GameGuruRepo/issues/5464#issuecomment-2285421190

LeeBamberTGC commented 2 days ago

@Ghost-l0l Now tagged correctly :)