search

TheGameSpider / TechnicSolder

A better version of https://github.com/TechnicPack/TechnicSolder
https://solder.cf
Other
22 stars 18 forks source link

Can't delete Forge Version #24

Open DoktorHeisenberg opened 4 years ago

DoktorHeisenberg commented 4 years ago

Describe the bug I want to delete a Forge version. I click on "Remove" and confirm the removal. The Forge version vanishes from the list, but if I reload the page or Login from another Browser (to avoid cache issues) it's still there.

To Reproduce Steps to reproduce the behavior:

  1. Go to Libraries -> Forge Versions -> Forge Versions in Database
  2. Click on "Remove" and "Delete" in the popup Window
  3. The Forge Version disappears.
  4. Reopen the page, it's still there.

Expected behavior The Forge Version should be deleted.

ZandercraftGames commented 3 years ago

@DoktorHeisenberg I too have the same issue... It seems to not do anything when you click delete... This likely is due to improper code not removing the file or version from the database, as I can still use it in modpacks and it works fine.

@TheGameSpider this shouldn't be too hard of an issue to fix as it likely just requires the code to be looked into quickly for what might be causing the files and database entry to not be deleted. It won't work, even if it isn't in any modpacks or builds at the moment.

cowpod commented 3 years ago

Fixed in PR #37 !