TheGameSpider / TechnicSolder

A better version of https://github.com/TechnicPack/TechnicSolder
https://solder.cf
Other
22 stars 19 forks source link

All mods in build are removed when using the update pack feature #4

Closed rmarmorstein closed 5 years ago

rmarmorstein commented 5 years ago

Describe the bug When using the update build feature, all mods from the previous build are lost upon clicking the save & refresh button/

To Reproduce Steps to reproduce the behavior:

  1. Click on update latest version from the New Build section
  2. Click save & refresh button after adding/removing mods

Expected behavior Mods are kept in the build and changes can be made from the previous version

Screenshots

Gif: https://i.imgur.com/LbiUE90.gifv

Additional context Using version Solder.cf v0.0.2.16 Beta

rmarmorstein commented 5 years ago

Update, still does this after updating to v0.0.2.17 Beta

It appears to be the same bug that was fixed in v0.0.2.9 according to the Change Log.

TheGameSpider commented 5 years ago

It works properly on php 7.2 - https://imgur.com/a/lUUwfei

rmarmorstein commented 5 years ago

I am running PHP 7.2

https://i.imgur.com/GZFn7GZ.png

I can supply the public PHP info page if you'd like privately.

TheGameSpider commented 5 years ago

It should work in 0.0.3.2 dev version

rmarmorstein commented 5 years ago

Can confirm this is fixed in the dev branch.

rmarmorstein commented 5 years ago

I spoke too soon, it is happening again on the dev branch as of this comment.

Here is the php settings that the server is using: https://solder.parm.wtf/info.php

TheGameSpider commented 5 years ago

Try updating to 0.0.3.3

TheGameSpider commented 5 years ago

Fixed in v1.0.0.rc2