Issue with UTF-8 encoding

TheGeneGenieProject / GeneGenie.Gedcom

A .Net library for loading, saving, working with and analysing family trees stored in the GEDCOM format.

GNU Affero General Public License v3.0

52 stars 23 forks source link

Issue with UTF-8 encoding #117

Open goossensk opened 1 year ago

goossensk commented 1 year ago

Hello, I'm having names with diacritics like ë, and they are not correctly imported using the UTF-8 enoding.

Debugging what is going wrong:

GedcomRecordReader.ReadHeaderRecord is checking for "UTF8", while its mentioned in the gedcome file as "UTF-8".
Even when I would update the gedcom file to use UTF8, then within this case, its only setting the charset and not setting any encoding itself.

goossensk commented 1 year ago

Updated and tested with the following fixed the issue for me.

case "UTF8": // this is correct, we will already have converted from utf8 charset = GedcomCharset.UTF16LE; enc = Encoding.UTF8; break; case "UTF-8": // this is correct, we will already have converted from utf8 charset = GedcomCharset.UTF16LE; enc = Encoding.UTF8; break;