search

TheGoddessInari / hamsket

Free and Open Source messaging and emailing app that combines common web applications into one.
GNU General Public License v3.0
880 stars 55 forks source link

No cursor in SSO pages #339

Open ericzolf opened 2 years ago

ericzolf commented 2 years ago

Steps to reproduce

  1. Configure Hangouts Chat or Google Calendar (probably others)
  2. Sign out
  3. Sign-in again using the SSO of your company (yeah, I know, tough one)

Expected behavior

The SSO page of my company has a cursor so that I know in which field I'm currently typing.

Actual behavior

The login page of Google, where I enter my company e-mail, has a cursor blinking, but when I am redirected to the authorization page of my company, there is no cursor and I don't know where I'll be typing. This said, focus with the mouse works, it's just not visible. This obviously doesn't happen in a standard browser (Chromium or Firefox).

ENVIRONMENT

Version: 0.6.3 Platform: linux (x64) Electron: 17.1.0 Chromium: 98.0.4758.102 Node: 16.13.0 BuildVersion: 32d4407 (grafted, HEAD, tag: 0.6.3, origin/32d44074b64d96804155700f3888c31303cb5a08) Thu, 3 Mar 2022 03:25:26 -0800

Does this happen upstream: don't know what upstream means in this context

Fedora 36, GNOME 42, X11

ericzolf commented 2 years ago

I just added Gitter to my tabs in Hamsket, and the SSO connection page of GitHub shows exactly the same behavior. That one should be easier to reproduce.

TheGoddessInari commented 2 years ago

If you tab away from Hamsket, and then back, do the input fields suddenly work?

Also, see if this happens/only happens on pages with autofocus attribute on (probably) the first input field. That's what Gitter/Github's SSO is doing that is apparently confusing something.

Hamsket has some logic to try to work around old Electron bugs regarding focus and blur, but I wouldn't be surprised if it's incomplete.

ericzolf commented 2 years ago

If you tab away from Hamsket, and then back, do the input fields suddenly work?

To be correct, they always work, they just don't show it, but, yes, you're right: clicking in another window then coming back makes the cursor appear.

Also, see if this happens/only happens on pages with autofocus attribute on (probably) the first input field. That's what Gitter/Github's SSO is doing that is apparently confusing something.

Let me check at work on Monday. How would I do this? With the developer tools I guess?