TheGreenPig / Apate

A BetterDiscord Plugin that allows End-to-End encryption and hiding messages in messages!
65 stars 17 forks source link

Apate v1.4.0 - Key Icon Gone? #37

Closed XxUnkn0wnxX closed 3 years ago

XxUnkn0wnxX commented 3 years ago

Hi, since updating to Apate v1.4.0 the key icon has vanished, however downgrading to 1.3.5 the icon comes back.. Screen Shot 2021-10-16 at 3 20 17 pm

Icon Gone??? Screen Shot 2021-10-16 at 3 20 29 pm

Stable 101451 (b46c230)
BetterDiscord 1.2.1
Host 0.0.264 OS X 10.15.7 (20.6.0)

Also none of the keyboard shortcuts work on the Mac. CTRL+ENTER does nothing, message wont send its just locks me out from sending anything.. (like all input is blocked) CTRL+SHIFT+ENTER - same thing CTRL+ALT+ENTER - same thing (ALT is Option key on Mac)

BTW these used to work on V 1.3.5

EDIT: working commit 669a8965e2982ea2e07ed2e6b52b59a93b44dad4 however when doing update from 1.3.5 using the plugin-in repo V1.4.0 is broken.

XxUnkn0wnxX commented 3 years ago

@TheGreenPig Commit: 669a8965e2982ea2e07ed2e6b52b59a93b44dad4 Constantly crashing when pressing keyboard shortcuts

[2021-10-16 04:50:38.073][CONSOLE:ERROR] {} Cannot set property 'props' of undefined
TypeError: Cannot set property 'props' of undefined

Full Log debug.log

TheGreenPig commented 3 years ago

Sorry about that... I think I should know to fix it though? If the key can't be added successfully, then no shortcuts will work. Give me some time and I should be able to fix it.

TheGreenPig commented 3 years ago

I think I fixed this in 1.4.1. If not, please tell me.

TempleAnkor commented 3 years ago

I am on 1.4.1 and no keyboard shortcuts or key icon show/work for me.

TheGreenPig commented 3 years ago

I am on 1.4.1 and no keyboard shortcuts or key icon show/work for me.

Can you please open up your console (Ctrl+Shift+i), restart Discord (Ctrl+R) and screenshot the errors (big red blocks) you get that come from Apate? It works on my end so I can't really reproduce the problem...

TempleAnkor commented 3 years ago

After refreshing discord a few times the plugin seems to work now for me. I have no idea what went wrong but now it works. Only thing I did was restart discord a few times. Sorry if this isn't much help.

XxUnkn0wnxX commented 3 years ago

@TheGreenPig Still Crashing hard on v1.4.3

however the cause is when using Copier plugin, when either Apate or Copier is off no conflicts, I'm not sure if this is something you need to fix @TheGreenPig or @Strencher https://github.com/Strencher/BetterDiscordStuff/tree/7a3d4ef04656e3cb8600ebf46a05072ea56659c6/Copier

when I send an encrypted message & followed by a non-encrypted one with keyboard shortcuts Then a 3rd one using the key it crashes.. & even after refreshing just trying to enter new messages in the same channels here those hidden messages are it just crashes..

Logs btt-debug.log discord_console.log

Screen Shot 2021-10-17 at 9 46 33 pm

Strencher commented 3 years ago

Could you please try out this version of Copier? I put a fix on it that should fix the conflict. https://cdn.discordapp.com/attachments/899251659572670505/899256097280499732/Copier.plugin.js

XxUnkn0wnxX commented 3 years ago

Could you please try out this version of Copier? I put a fix on it that should fix the conflict. https://cdn.discordapp.com/attachments/899251659572670505/899256097280499732/Copier.plugin.js

Yep all good ;)