search

TheGreyGhost / MinecraftByExample

Working sample code for the basic concepts in Minecraft and Forge.
Other
1.24k stars 187 forks source link

Updated mappings #23

Closed tomelfring closed 7 years ago

tomelfring commented 7 years ago

Hi, First off, thank you for your great examples, learned a lot of it. A little remark on your 1.11 branch. You're explaining the use of itemStack.func_190926_b() (for example) and that it will change in the future. It already is changed. You only need to update your mappings in the build.gradle file to something more recent. In the latest mappings all itemStack changes are properly named to increase, decrease, ItemStack.EMPTY and so on.

It could save everyone some time to read, write and understand the code.

TheGreyGhost commented 7 years ago

Hi thanks for the comments and the suggestion I did think about updating the mapping, the mapping I used is the one that Forge is still using, and last time (in 1.8.9) that I tried to update to a newer version of the mapping than Forge, all hell broke loose when I tried to build it.

But I'll give it a go on a separate branch, because you're right those obfuscated names suck.

Cheers TGG

TheGreyGhost commented 7 years ago

Done.

tomelfring commented 7 years ago

Thank you!

TheGreyGhost commented 7 years ago

no worries :)

  From: Tom E <notifications@github.com>

To: TheGreyGhost/MinecraftByExample MinecraftByExample@noreply.github.com Cc: TheGreyGhost spamblackhole88@yahoo.com.au; State change state_change@noreply.github.com Sent: Friday, 10 February 2017, 17:54 Subject: Re: [TheGreyGhost/MinecraftByExample] Updated mappings (#23)

Thank you!— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.