.gitignore, and script permissions fix

TheGreyGhost / MinecraftByExample

Working sample code for the basic concepts in Minecraft and Forge.

Other

1.24k stars 187 forks source link

.gitignore, and script permissions fix #32

Closed Lohoris closed 5 years ago

Lohoris commented 7 years ago

Created a .gitignore to ignore all the file and directories generated by gradlew.

Also, added execute permissions for gradlew bash script, and renamed to gradlew.sh.

dreadnaut commented 5 years ago

@TheGreyGhost uh, could you explain why this is being closed?

Pull requests being closed without a comment can be off-putting for contributors :slightly_frowning_face:

TheGreyGhost commented 5 years ago

Hi Dreadnaut

Thanks for the feedback, you're right I should add a comment. I closed it because of its age and because it has been superceded by the next Forge MDK (the gradlew and gitignore are copied straight from the MDK)

Cheers TGG

dreadnaut commented 5 years ago

Thank you for the explanation, and your work on MbE!

TheGreyGhost commented 5 years ago

No worries, you're welcome :)