TheGreyGhost / MinecraftByExample

Working sample code for the basic concepts in Minecraft and Forge.
Other
1.24k stars 187 forks source link

add new sections to MBE #52

Closed dealingwith closed 5 years ago

dealingwith commented 5 years ago

This adds five new sections to MinecraftByExample:

Ask and ye shall receive! 😄

These are some new sections we needed for our Minecraft U curriculum. Hopefully, they're all self-explanatory in terms of what they're doing/demonstrating.

Notes

dealingwith commented 5 years ago

@atvaccaro I noticed that mbe17_block_crops still needed some love...pushed what I got done tonight, still a WIP...

TheGreyGhost commented 5 years ago

howdy Great! thanks very much for that!

Please let me know when you think it's ready for merge, I'll have a browse in the meantime and let you know if there's anything that doesn't seem right.

I'm not too worried about the numbering scheme, there are rough groupings to help organise by theme but it's not likely to be confusing. your mbe10_2_tool_simple would be fine or you could use mbe10a_tool_simple as well. The main idea with the separate sections was to make each example as self-contained as possible, i.e. to give a very clear visual picture of what components are needed to get that particular feature working, with no links at all to any other example.

I've had some ideas for other sections which I never got to, these include

Entities basic entity that can be spawned and disappears after a certain time missile entity entity rendering / techne -based / animation entity with basic AI

Sound

Terrain generation

Generate a new dimension

Different rendering modes

Miscellaneous best practice error logging

Places to store extra data.... WorldSavedData

TheGreyGhost commented 5 years ago

Forgot to mention - I'm about to start updating for 1.13 although I believe the Forge guys are probably going to skip over it directly to 1.14.

One of the most pervasive changes will probably be changing some (or most?) of the examples to the new block/item registration system using annotations instead of explicitly registering them. I deliberately didn't do that change for 1.12 because it was a bit new at the time, but it should have been bedded down properly by now (I hope). I plan to leave the old registration method in there for reference as well.

atvaccaro commented 5 years ago

That sounds like an awesome change; the current registration is very cumbersome.

atvaccaro commented 5 years ago

Where do you get your information for version changes? Or is it trial-and-error?

dealingwith commented 5 years ago

Ok we just removed 17, so this should be good for review now.

dealingwith commented 5 years ago

Forgot some deletions, standby...

dealingwith commented 5 years ago

I'll squash these as well once it's ready ready

dealingwith commented 5 years ago

Ok fixed and squashed the new commits! Ready for 🚀

dealingwith commented 5 years ago

@TheGreyGhost any idea of if/when you might merge these into master?

TheGreyGhost commented 5 years ago

hi sorry for the complete silence, I've been working on another project in the meantime I think the pull request needs a reasonable amount of time to make it align with the rest of MBE, in particular in some cases I want to enhance the example to make it more instructive. I still plan to do it, but I think it will take me several weeks to complete. cheers TGG

dealingwith commented 5 years ago

Cool, thanks for the update!