Pull Request People

[fkj]

Since we have a lot of pull requests I was thinking, is there anyhing that holds us back from just merging them into the main branch?

If no one responds to this with a reason as to why we should not do this within 24 hours I will merge all pull requests into the main branch.

Just thought I would let you guys know.

[oskarihiltunen]

I think there are two possible reasons to why they haven't been merged:

• No one with such power has been here.
• The people with such power are unsure of whether they are allowed to use it or not. Making everyone an author may cause such uncertainty, as then the people with power aren't actually any kind of authorities, just regular users. If only a selected few would be given such power they would be clear authorities. And if these people were selected well, they would improve the level of code by checking what's merged. This set-up is actually really similar to TH.net's WC3 resource approval process.

I think you opening this issue kinda implies the second option is more likely - you are clearly here and clearly have no clue about whether you're allowed to merge them or not.

Btw, I don't think 2 is "a lot" (#9 is #7 with a couple of additional commits). ^_^

[fkj]

2 is a lot when it equals to about 100% of the code that's already there :P

Anyway, the reason for this issue is mainly to establish those selected few, since miz is apparently not on much(?), and there is not really anyone else doing it.

[fkj]

Ok, I'm pulling everything that can merge without problems now. We still need to appoint someone to officially do thids this though.