search

TheHive-Project / Cortex-Analyzers

Cortex Analyzers Repository
https://TheHive-Project.github.io/Cortex-Analyzers/
GNU Affero General Public License v3.0
430 stars 374 forks source link

[Bug] HIBP Analyser no longer works #524

Closed znb closed 4 years ago

znb commented 5 years ago

Describe the bug On July 2019 they updated the API to use authentication. All queries will now fail.

To Reproduce Steps to reproduce the behavior:

  1. Run the HIBP analyser
  2. ???
  3. Profit
  4. Nope.

Expected behavior A valid response from the API.

Possible solutions We need to update the analyser to take an API key in the configuration.

There will be changes to the analyser code:

  1. Change to the v3 API
  2. Adding in authentication header
mgabriel-silva commented 5 years ago

Same problema here: "errorMessage": "API Access error: This version of the API has been discontinued, please use V3: https://www.troyhunt.com/authentication-and-the-have-i-been-pwned-api/"

jeromeleonard commented 5 years ago

hello,

thanks to @jonashergenhahn for the PR https://github.com/TheHive-Project/Cortex-Analyzers/pull/525 that should fix this. The new version of this analyzer has been merged in develop branch. As API subscription are temporary disabled I have not been able to test. Please make some test on your side and tell us if everything is fine.