Add Docker build and fix spelling

TheHolm / meraki-dashboard-promethus-exporter

Promethus exporter to collect data from Meraki dashboard via API

GNU General Public License v3.0

3 stars 8 forks source link

Add Docker build and fix spelling #1

Closed cablespaghetti closed 3 years ago

cablespaghetti commented 3 years ago

Hi. Thanks for building this, it's saved us a lot of effort!

This PR creates a basic Docker build using a "push-to-ghcr" Github action which works without any further repository configuration. I've also fixed the spelling of Prometheus in a few places.

In addition I've now added the ability for the API key to be picked up from an environment variable by switching to ConfigArgParse. This makes life easier when running in Docker (or Kubernetes in my case) and wanting to inject the key securely.

TheHolm commented 3 years ago

Thank you. Nice addition. Could you please add note about using environment variables to README.md. And may be remark Docker?

cablespaghetti commented 3 years ago

Done 👍

TheHolm commented 3 years ago

Thank you. Merged.