TheHortonMachine / hortonmachine

The Horton Machine
http://thehortonmachine.github.io/hortonmachine/
GNU General Public License v3.0
43 stars 25 forks source link

multiple code improvements: squid:S1149, squid:S1118, squid:CommentedOutCodeLine, squid:S2293, squid:S1157, squid:S1488 #23

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S1149 - Synchronized classes Vector, Hashtable, Stack and StringBuffer should not be used. squid:S1118 - Utility classes should not have public constructors. squid:CommentedOutCodeLine - Sections of code should not be "commented out". squid:S2293 - The diamond operator ("<>") should be used. squid:S1157 - Case insensitive string comparisons should be made without intermediate upper or lower casing. squid:S1488 - Local Variables should not be declared and then immediately returned or thrown. You can find more information about the issue here: https://dev.eclipse.org/sonar/coding_rules#q=squid%3AS1149 https://dev.eclipse.org/sonar/coding_rules#q=squid%3AS1118 https://dev.eclipse.org/sonar/coding_rules#q=squid%3ACommentedOutCodeLine https://dev.eclipse.org/sonar/coding_rules#q=squid%3AS2293 https://dev.eclipse.org/sonar/coding_rules#q=squid%3AS1157 https://dev.eclipse.org/sonar/coding_rules#q=squid%3AS1488 Please let me know if you have any questions. George Kankava