TheHortonMachine / hortonmachine

The Horton Machine
http://thehortonmachine.github.io/hortonmachine/
GNU General Public License v3.0
43 stars 25 forks source link

Use stac asset id as the identifier #89

Closed inigo-cobian closed 1 year ago

inigo-cobian commented 1 year ago

Hi! This is my first Pull Request on this repository.

This small change I am proposing would make the id of the asset the primary identifier of a HMStacAsset. Currently, the "title" field is being used, but this could cause issues as that field might not exist or might not be unique (link to the docs).

I would like to know if there some standards I should follow before sending you a non-draft Pull Request. I was thinking on creating some tests to validate the changes. How should they be added?