search

TheIdentitySelector / thiss-js

The identity selector software source
Other
14 stars 23 forks source link

Lists should have list items not hyperlinks as childs #279

Closed Bojhan closed 1 month ago

Bojhan commented 1 month ago

We currently put list items (a) as childs of (ul). This is not valid, the a should be contained in the li.

This was done previously to allow for the entire li to be clickable, however nowadays there are better techniques to do this that do not break WCAG compliance.

Example:

<ul id="ds-search-list" class=""><a class="institution identityprovider bts-dynamic-item" data-href="https://singlesignon.gwu.edu/idp/shibboleth">
    <li aria-label="Select The George Washington University" tabindex="0"><i class="arrow" data-fa-i2svg=""><svg class="svg-inline--fa fa-angle-right fa-w-8" aria-hidden="true" focusable="false" data-prefix="fa" data-icon="angle-right" role="img" xmlns="..."></path></svg></i>
        <div class="d-block institution-text">
            <div class="text-truncate label primary">The George Washington University</div>
            <div class="text-truncate label-url secondary">gwu.edu</div>
        </div>
    </li>
</a></ul>
enriquepablo commented 1 month ago

In the results listing (#ds-search-list) I see the a elements inside li elements, I'm not sure what you mean

enriquepablo commented 1 month ago

Done in version 2.0.1