Using Dedicated Server, Bobber entity breaks registry then makes client unable to read any packets.

[Kaleidio]

Versions (Be specific, do not write "latest"):

• Combustive Fishing: 4.0.0.1
• Forge: 1.16.5-36.2.22

  Observed Behavior:

  the log shows that the bobber entity provided by this mod breaks during registry trades between dedicated server and client. then the client log spams as it gets a null for every packet received, making the client freeze and unable to connect to server.

  Expected Behavior:

  this should not occur. I believe the issue is caused by differences in the forge API between 1.16.3 and current.

  Steps to Reproduce:

  1. use the mod on a dedicated server
  2. try to connect to the server ...

Crash Log: https://pastebin.com/1hXMB9cL

Further info: I just discovered this, I have yet to test for mod collisions, will provide a new log if I eventually get around to testing with minimal mod selection

[TheIllusiveC4]

It looks like there's some kind of Flash NPC mod that is further up the stacktrace. Do you recognize which mod that could be? If so, does this issue occur if you remove that mod?

[Kaleidio]

Flash's NPCs only collides with mods if you wrote your constructor, data tags, nbt system in a way that isn't vanilla like (such as removing abilities that Entities inherit from the base class). If that really is the issue then you need to make sure the Bobber entity is being constructed in a way that is as similar to the normal bobber as possible.

[Kaleidio]

I will have to run the test tomorrow as I am busy

[Kaleidio]

Removing flash npc's did fix the issue. However as I said before that shouldn't happen if you were being modfriendly with the entity. I suggest taking a look at Flash's codebase to see if you can repair this.

https://github.com/FlashHUN/FlashNPCs