TheIllusiveC4 / CombustiveFishing

Combustive Fishing is a mod that adds a few items and features that allow you to fish in lava.
Other
5 stars 3 forks source link

[1.12.2] The golden fishing rod does not provide the player in loot context when generating loot #5

Closed Luke616 closed 5 years ago

Luke616 commented 5 years ago

The golden fishing rod does not provide the player in loot context when generating loot, as the vanilla fishing pole does. This causes loot conditions referencing the player's location to automatically fail when they are called in the fishing/junk/treasure loot pools.

For example, as a pack maker I created a script which replaced the fishing loot pool with one that checked the player's biome and allowed different fish to be caught in different biomes using morelootstuff's in_biome condition. This worked great for the vanilla fishing pole, but caused the golden fishing rod to be unable to catch any of those fish.

Thanks!

Using: Combustive Fishing 1.0.3.2 Minecraft 1.12.2 Forge 2768