TheImagingSource / ic4-examples

IC4 Example Programs
Apache License 2.0
5 stars 3 forks source link

Question re IC2.5 WDR settings? #17

Open g40 opened 3 months ago

g40 commented 3 months ago

image

The TIS IC Capture 2.5 application has exposes the property page shown above. Are these settings renamed in IC4 or have they been removed/not yet implemented?

Thanks.

TIS-Edgar commented 3 months ago

Hi, The feature should still be available. It should under "Tone Mapping Control". The ic4-demoapp property dialog should allow you to search for "Tone Mapping" to verify this.

With IC4 all camera properties are now GenICam Standard Features Naming Convention (SFNC) compatible. This means that some properties might have been renamed to be compliant. The majority of properties should remain unchanged between 3.5 and 4.

g40 commented 3 months ago

@TIS-Edgar Thank you. I'll check it out.

g40 commented 3 months ago

@TIS-Edgar Using the 1.0.0.2416 build, no Tone Mapping property can be found -

image

TIS-Edgar commented 3 months ago

ok, that should list the tone mapping properties. So something is fishy.

What version of the gige gentl provider is installed?

g40 commented 3 months ago

1.1.0.674 dated 18/03/24. See below.

image

TIS-Edgar commented 3 months ago

The IC4 and gentl provider versions both support tone mapping. Can you save the genicam document and give it to us? Open IC4 Demo App and click: Device -> Driver Properties -> Guru -> 'StoreRemoteDeviceGenICamDocument'

The xml file will contain a complete description of what the camera properties are.

g40 commented 3 months ago

@TIS-Edgar: Please find attached. Simply remove .txt extension to get original XML (which is an unsupported upload on Github)

DFK 33GX545_RemoteDevice.xml.txt

TIS-Edgar commented 3 months ago

Thank you. The xml contains ToneMappingEnable and other properties, meaning camera and driver are exporting the property correctly.

Two possibilities come to mind that might hide tone mapping:

  1. The property SoftwareTransformEnable has to be On. It should have that value per default, but better to check.
  2. What PixelFormat are you using? ToneMapping should be available for all PixelFormat, but it might very well be a bug for one. Does switching the format make a difference?
g40 commented 3 months ago

@TIS-Edgar It looks like the pixel format affects the properties. How do we gt tone properties using BGR8?

Thanks.

image

Using BGR8

image

TIS-Edgar commented 3 months ago

You found a bug in our gige provider! BGR8 should also have Tone Mapping. We will fix that in our next driver release. Not certain about the time frame, so cannot comment on that yet.

As a potential workaround: Set PixelFormat to BayerX and the sink PixelFormat to BGR8. You can do that in the sink constructor. You will have higher cpu usage due to the conversion but lower network load when using this.

g40 commented 2 months ago

@TIS-Edgar Any news on this one? Thanks.

TIS-Edgar commented 2 months ago

No not yet, sorry.