search

TheInterventionCentre / NorMIT-Plan

10 stars 1 forks source link

Warnings in vtkVesselSegHelper.cxx: unused variables #47

Closed RafaelPalomar closed 6 years ago

RafaelPalomar commented 7 years ago

[ 75%] Building CXX object VesselSegmentation/Logic/CMakeFiles/vtkSlicerVesselSegmentationModuleLogic.dir/vtkVesselSegHelper.cxx.o /home/rafael/src/NorMIT-Plan/VesselSegmentation/Logic/vtkVesselSegHelper.cxx: In static member function ‘static vtkSmartPointer vtkVesselSegHelp\ er::ConvertItkImageToVtkImageData(itk::Image<unsigned int, 3u>::Pointer)’: /home/rafael/src/NorMIT-Plan/VesselSegmentation/Logic/vtkVesselSegHelper.cxx:377:42: warning: variable ‘origin’ set but not used [-Wunused-but-set-variable] itk::Image<unsigned int, 3>::PointType origin = itkImage->GetOrigin(); ^ /home/rafael/src/NorMIT-Plan/VesselSegmentation/Logic/vtkVesselSegHelper.cxx: In static member function ‘static vtkSmartPointer vtkVesselSegHelp\ er::ConvertItkImageToVtkImageData(itk::Image<float, 3u>::Pointer)’: /home/rafael/src/NorMIT-Plan/VesselSegmentation/Logic/vtkVesselSegHelper.cxx:417:30: warning: variable ‘imageSpacing’ set but not used [-Wunused-but-set-varia\ ble] SeedImageType::SpacingType imageSpacing = itkImage->GetSpacing();

RafaelPalomar commented 6 years ago

I get some more warnings:

/home/rafael/src/NorMIT-Plan/VesselSegmentation/Logic/vtkSlicerVesselSegmentationLogic.cxx:263:30: warning: unused parameter ‘caller’ [-Wunused-parameter] OnMRMLMarkupAdded(vtkObject caller, ^ /home/rafael/src/NorMIT-Plan/VesselSegmentation/Logic/vtkSlicerVesselSegmentationLogic.cxx:265:27: warning: unused parameter ‘callData’ [-Wunused-parameter] void clientData, void *callData)

/home/rafael/src/NorMIT-Plan/VesselSegmentation/Logic/vtkVesselSegHelper.cxx: In static member function ‘static vtkSmartPointer vtkVesselSegHelper::ConvertItkImageToVtkImageData(itk::Image<unsigned int, 3u>::Pointer)’: /home/rafael/src/NorMIT-Plan/VesselSegmentation/Logic/vtkVesselSegHelper.cxx:377:42: warning: variable ‘origin’ set but not used [-Wunused-but-set-variable] itk::Image<unsigned int, 3>::PointType origin = itkImage->GetOrigin(); ^ /home/rafael/src/NorMIT-Plan/VesselSegmentation/Logic/vtkVesselSegHelper.cxx: In static member function ‘static vtkSmartPointer vtkVesselSegHelper::ConvertItkImageToVtkImageData(itk::Image<float, 3u>::Pointer)’: /home/rafael/src/NorMIT-Plan/VesselSegmentation/Logic/vtkVesselSegHelper.cxx:417:30: warning: variable ‘imageSpacing’ set but not used [-Wunused-but-set-variable] SeedImageType::SpacingType imageSpacing = itkImage->GetSpacing();

/home/rafael/src/NorMIT-Plan/VesselSegmentation/MRMLDM/vtkMRMLVesselSegmentationDisplayableManager.cxx:130:33: warning: unused parameter ‘modifiedNode’ [-Wunused-parameter] OnMRMLNodeModified(vtkMRMLNode modifiedNode) ^ /home/rafael/src/NorMIT-Plan/VesselSegmentation/MRMLDM/vtkMRMLVesselSegmentationDisplayableManager.cxx:141:37: warning: unused parameter ‘node’ [-Wunused-parameter] OnMRMLSceneNodeRemoved(vtkMRMLNode node) ^ /home/rafael/src/NorMIT-Plan/VesselSegmentation/MRMLDM/vtkMRMLVesselSegmentationDisplayableManager.cxx:151:85: warning: unused parameter ‘caller’ [-Wunused-parameter] void vtkMRMLVesselSegmentationDisplayableManager::OnFiducialNodeModified(vtkObject caller, unsigned long int id, void clientData, void callerData) ^ /home/rafael/src/NorMIT-Plan/VesselSegmentation/MRMLDM/vtkMRMLVesselSegmentationDisplayableManager.cxx:151:111: warning: unused parameter ‘id’ [-Wunused-parameter] void vtkMRMLVesselSegmentationDisplayableManager::OnFiducialNodeModified(vtkObject caller, unsigned long int id, void clientData, void callerData) ^ /home/rafael/src/NorMIT-Plan/VesselSegmentation/MRMLDM/vtkMRMLVesselSegmentationDisplayableManager.cxx:151:139: warning: unused parameter ‘callerData’ [-Wunused-parameter] void vtkMRMLVesselSegmentationDisplayableManager::OnFiducialNodeModified(vtkObject caller, unsigned long int id, void clientData, void callerData) ^ /home/rafael/src/NorMIT-Plan/VesselSegmentation/MRMLDM/vtkMRMLVesselSegmentationDisplayableManager.cxx:178:161: warning: unused parameter ‘callData’ [-Wunused-parameter] void vtkMRMLVesselSegmentationDisplayableManager::OnCrosshairPositionModified(vtkObject caller, long unsigned int vtkNotUsed(eventId), void clientData, void callData) ^ /home/rafael/src/NorMIT-Plan/VesselSegmentation/MRMLDM/vtkMRMLVesselSegmentationDisplayableManager.cxx:222:82: warning: unused parameter ‘caller’ [-Wunused-parameter] void vtkMRMLVesselSegmentationDisplayableManager::OnSliceNodeModified(vtkObject caller, unsigned long int id, void clientData, void callerData) ^ /home/rafael/src/NorMIT-Plan/VesselSegmentation/MRMLDM/vtkMRMLVesselSegmentationDisplayableManager.cxx:222:108: warning: unused parameter ‘id’ [-Wunused-parameter] void vtkMRMLVesselSegmentationDisplayableManager::OnSliceNodeModified(vtkObject caller, unsigned long int id, void clientData, void callerData) ^ /home/rafael/src/NorMIT-Plan/VesselSegmentation/MRMLDM/vtkMRMLVesselSegmentationDisplayableManager.cxx:222:136: warning: unused parameter ‘callerData’ [-Wunused-parameter] void vtkMRMLVesselSegmentationDisplayableManager::OnSliceNodeModified(vtkObject caller, unsigned long int id, void clientData, void *callerData)

/home/rafael/src/NorMIT-Plan/VesselSegmentation/Testing/Cxx/vtkMRMLTestFiducialList.cxx: In function ‘bool testAddFiducial(const char, vtkSlicerVesselSegmentationLogic)’: /home/rafael/src/NorMIT-Plan/VesselSegmentation/Testing/Cxx/vtkMRMLTestFiducialList.cxx:80:9: warning: variable ‘fidIndex’ set but not used [-Wunused-but-set-variable] int fidIndex = fidNode->AddFiducial(inPos[0], inPos[1], inPos[2]); ^ [ 98%] Building CXX object VesselSegmentation/Testing/Cxx/CMakeFiles/qSlicerVesselSegmentationModuleCxxTests.dir/vtkMRMLTestFileAndSegmentation.cxx.o /home/rafael/src/NorMIT-Plan/VesselSegmentation/Testing/Cxx/vtkMRMLTestFileAndSegmentation.cxx: In function ‘bool testLoadFileAndSegment(const char, const char, vtkSlicerVesselSegmentationLogic*)’: /home/rafael/src/NorMIT-Plan/VesselSegmentation/Testing/Cxx/vtkMRMLTestFileAndSegmentation.cxx:121:9: warning: variable ‘fidIndex’ set but not used [-Wunused-but-set-variable] int fidIndex = fidNode->AddFiducial(inPos[0], inPos[1], inPos[2]);

RafaelPalomar commented 6 years ago

Louise, please notice that these warnings happen in the code you pull-requested. Fix them as soon as we fix the pull-request