lcoram
commented
6 years ago In the logic now poll for the active volume when needed. Have tried to reduce the line length, and larger if bodies. Using debug macro for timing and a few other informational print outs.
There are functions for propagating the volume selection (also used in the widget, for the dropdown), so this fixes the issue to do with that.
Also, comprehensive error testing in the logic test, and also a good use case test for segmentation (renamed - for better naming convention).
I have some thoughts / questions about the design of the seed node... should we actually have nodes that contain 1 seed not 2, and then pass 2 seed nodes into the segmentation function. The question is in the long term how will we handle seeds? Will we want to keep a list of them (e.g. when seed nodes are added to scene we keep track of them in a list of seeds)? Or do we just want to poll the scene when calling the segmentation or split function and have the software ensure there is only ever one seed node (and if there is none do not call the function)?