TheJacksonLaboratory / LIRICAL

LIkelihood Ratio Interpretation of Clinical AbnormaLities
https://thejacksonlaboratory.github.io/LIRICAL/stable
Other
22 stars 11 forks source link

Not implementation #422

Closed pnrobinson closed 5 years ago

pnrobinson commented 5 years ago

List diseaseExcludedTerms = disease.getNegativeAnnotations(); Set queryancestors = getAncestorTerms(ontology,tid,true);

The implementation is reversed (you don't notice this if the excluded term is the same in deisease and query of course). If a patient as NOT for term t, then if the disease is NOT for that term or NOT for any of the descendents of the term, then there is a NOT-NOT match.

pnrobinson commented 5 years ago

fixed