TheJacksonLaboratory / LIRICAL

LIkelihood Ratio Interpretation of Clinical AbnormaLities
https://thejacksonlaboratory.github.io/LIRICAL/stable
Other
22 stars 11 forks source link

Gene LR in its own column? #477

Closed pnrobinson closed 4 years ago

pnrobinson commented 4 years ago
Suggestion: Move the gene LR bar to its own column -- advantage: right now it is impossible to know from the sparkline that the last column refers to the gene LR -- disadvantage: An isolated box would be hard to grok. @jmcmurry Maybe there is some other way of highlighting the gene LR?
jmcmurry commented 4 years ago

Some things to try:

justaddcoffee commented 4 years ago

Another possible thing to address this would be mouseover tooltips with some labels to describe what each LR bar is

pnrobinson commented 4 years ago

@jmcmurry Actually, tool tips would be a better way of displaying the complicated information about the phenotypes that is now shown as a block of text. @justaddcoffee I like the idea of tool tips but it would be great to avoid JavaScript. Here seems to be a way of doing it with CSS coolness (https://bl.ocks.org/mqg/24da58ffac19ba2fdaab).

jmcmurry commented 4 years ago

Tooltip on hover (for any bar) is a great idea; agree it could be a good way of exploring the complex info currently a block of text, but it is probably not sufficient in itself.

Given that horizontal space is still quite generous I still recommend either some white space buffer or a separate column.

pnrobinson commented 4 years ago

@jmcmurry This is definitely not intended for use on mobiles, and we should simply not worry about that. In conversation we discussed removing the black outline for the gene on the sparkline. I have been thinking and am not sure that we should add space between the phenotypes and the gene. The sparkline is intended to be an overview and the more detailed exploration should occur in the main sections. I think that once users start exploring they will "get it" that the last item is a gene. Anybody who uses this tool will probably be using it for many cases and so there will be a learning curve that it inavoidable!

jmcmurry commented 4 years ago

In the interest of specificity before we abandon ship, here's my recommendation. Are you quite certain you prefer it all together with phenotypes? I find this both clear and simple.

image

pnrobinson commented 4 years ago

@jmcmurry This does look nice! Let me try to implement this. I think it will mean creating an extra SVG string for the gene boxes and adding an option for the HTML template for whether or not LIRICAL was run in phenotype-only mode

pnrobinson commented 4 years ago

@jmcmurry -- how about this?

image

pnrobinson commented 4 years ago

@jmcmurry Improved version

image

pnrobinson commented 4 years ago

Should we call "Profile match" simply "Phenotypes"?

pnrobinson commented 4 years ago

done

jmcmurry commented 4 years ago

great, thanks all :)