TheJacksonLaboratory / LIRICAL

LIkelihood Ratio Interpretation of Clinical AbnormaLities
https://thejacksonlaboratory.github.io/LIRICAL/stable
Other
22 stars 11 forks source link

VCF file is available at /path/to/data/Pfeiffer.vcf #492

Closed vidarmehr closed 4 years ago

vidarmehr commented 4 years ago

@pnrobinson @justaddcoffee In documentations: https://lirical.readthedocs.io/en/latest/phenopacket-hpo.html and
https://lirical.readthedocs.io/en/latest/phenopacket-vcf.html,

it is written that "VCF file is available at /path/to/data/Pfeiffer.vcf." Does it mean that when data directory is downloaded by the user, pfeiffer.vcf is also downloaded? I only see pfeiffer.json and pfeifferNoVcf.json in /test/resources/phenopacket.

justaddcoffee commented 4 years ago

I don't think we've included Pfeiffer.vcf, but if we have the data rights we maybe should include this

pnrobinson commented 4 years ago

/path/to/data/ is intended to be an example only. There is no path that starts with /path !! maybe we should write /example/path/... ?

vidarmehr commented 4 years ago

I thought /path/to/data/ is the path to the Exomiser data. If you want the user to test LIRICAL on Pfeiffer.vcf, then I think it is better to put it in /example/path/....

pnrobinson commented 4 years ago

I have changed everyting to /example/path/...