TheJacksonLaboratory / LIRICAL

LIkelihood Ratio Interpretation of Clinical AbnormaLities
https://thejacksonlaboratory.github.io/LIRICAL/stable
Other
22 stars 11 forks source link

Modularize code #561

Closed ielis closed 1 year ago

ielis commented 2 years ago

Hi @pnrobinson ,the PR aims to split Lirical into smaller pieces, remove the redundant code, and upgrade the dependencies.

Java is bumped to 17, we use Phenol v2.0.0-RC1. The code uses biodownload in the download command.

The CLI includes 3 commands for running analysis, the commands differ by how the input data (path to VCF, phenotype, etc..) is provided:

There are many CLI arguments, thus the analysis commands are split into 4 argument groups:

This PR is still a draft, I haven't finished the non-analytic commands (simulate, grid, etc.), nor any non-standard (age of onset-related) functionality.

If you have a chance, please try to run a file or two to check if it works OK.

ielis commented 2 years ago

Hi @pnrobinson , I think that this branch amassed a lot of material and we should consider merging to develop. I think we're close to v2 release but I'd like to ask you to look at the code and results to make sure I did not do anything stupid. Can we plan on touching bases in the next days?

pnrobinson commented 2 years ago

@ielis let's go over this tomorrow. In particular, we should run a test suite over the 384 phenopackets and check we are getting the same results!