search

TheJacksonLaboratory / Phenomiser

Phenotype-based Diagnosis Tool for Rare Diseases
6 stars 4 forks source link

Fix expansion error #31

Closed kingmanzhang closed 5 years ago

kingmanzhang commented 5 years ago

I am trying to fix unnecessary parent expansion. Also proposed a new class for calculating rank -> Item2PValueAndSimilarity to replace SearchResult so that we can reuse the multiple test correction codes in phenol. Otherwise, we will have to re-invent the codes.

A patch for phenol is required: https://github.com/monarch-initiative/phenol/pull/200

I have not tried to fix calculating rank (https://github.com/TheJacksonLaboratory/Phenomiser/issues/21) since you are also working on this. We can adapt your code together.

Please help review when you have time. @vidarmehr

kingmanzhang commented 5 years ago

The other pull request contains everything in this branch.