search

TheJacksonLaboratory / PhenopacketLab

An Angular/Springboot web application for the loading, editing, saving of data that follows the Phenopacket Schema
BSD 3-Clause "New" or "Revised" License
8 stars 2 forks source link

Add info box with description and id on searchable ontology terms #112

Closed belkassaby closed 1 year ago

belkassaby commented 1 year ago

Definition of done

when hovering a particular term from an ontology (on a dropdown or elsewhere) we should display a description dialog/tooltip with the corresponding id and description of the said term. The id could also link to the external page for the given term.

belkassaby commented 1 year ago

See commit 2826f5

desais-jax commented 1 year ago

@belkassaby I see the ontology details only in disease Ontology drop down. Is there any other place where I should be viewing the tooltip or dialog?

belkassaby commented 1 year ago

@desais-jax Anywhere where there is some sort of ontology (a dropdown UI most of the time) I should show the ID and possibly the description as well as the label. I think it should show the label as ' [id] label' in any ontology dropdown, and if possible a tooltip on each item with the corresponding description.

desais-jax commented 1 year ago

@belkassaby :looks good now. But I see the ID but i see prefix from CL and GO and UBERON. Is that correct. I thought we were only iimporting from HPO site. Are we integrating with some other application too inorder to get the ontologies?

belkassaby commented 1 year ago

@belkassaby yes, the disease ontology for instance comes from an ingested file which is built from the mondo ontology (and which has terms from different ontologies, orpha, go etc). We get the phenotypic features from the HPO ontology.