search

TheJacksonLaboratory / PhenopacketLab

An Angular/Springboot web application for the loading, editing, saving of data that follows the Phenopacket Schema
BSD 3-Clause "New" or "Revised" License
8 stars 2 forks source link

Gene Descriptor alternate ID not saved #159

Closed BethSundberg closed 1 year ago

BethSundberg commented 1 year ago

I created an intervention. Down at the very end, I can enter a gene descriptor. One option is to enter an alternate ID. I put something there by clicking on the "new" button. However, my value was not saved? - it does not appear when I uploaded the json.

Image

pnrobinson commented 1 year ago

We should prob. not allow people to use the GeneDescriptor element -- they should be required to use the VariantInterpretation!

BethSundberg commented 1 year ago

@belkassaby This is tied to issue 306. Right now for a new interpretation, I can add the "description". RE: Peter's comment, should this not be displayed at all unless there is an uploaded phenopacket? i.e. don't allow adding anything here, only display existing information.

BethSundberg commented 1 year ago

The alternate ID now is saving in the json.