search

TheJacksonLaboratory / PhenopacketLab

An Angular/Springboot web application for the loading, editing, saving of data that follows the Phenopacket Schema
BSD 3-Clause "New" or "Revised" License
8 stars 2 forks source link

Please select interpretation status for genomic interpretation. #188

Closed pnrobinson closed 1 year ago

pnrobinson commented 1 year ago

This appears even though I have created an interpretation

belkassaby commented 1 year ago

I will set the default value of the interpretation status (property of genomic interpretation) to UNKNOWN as the UI doesnt not allow to create an interpretation with a genomic interpretation without its interpretation status. I did this as it is a required property if there is a genomic interpretation in an interpretation object.

pnrobinson commented 1 year ago

This makes sense. However, it would be good to have a warning if the user tries to submit the interpretation with UNKNOWN status because there are very few use cases where this would make sense (we expect the interpretation to be CAUSAL or CONTRIBUTORY in 99% of sensible use cases)

BethSundberg commented 1 year ago

The default value is set. However, there is no warning about unknown status. I am moving this back to In Progress

BethSundberg commented 1 year ago

Warning is now present