Bug: Several problems with step 1: Individual information

[BethSundberg]

When entering individual information in create a phenopacket step1, the following bugs/issues/suggestions were found. See the list in the attached word document.

Phenopacket new issue suggestions June 2023.docx

[belkassaby]

List of Bug/enhancement found

• [x] save whether the "I confirm that this ID is not a medical record..." has already been selected if going back in the stepper process: fixed in dev branch, see #192
• [x] Rare disease : this is fixed in the current dev branch as we removed the other profile where the steps hadn't been developped yet. even if a phenopacket has been created with the rare profile, we should show each possible part of a phenopacket)
• [x] Sex not saved properly (see #175): fixed in dev branch
• [x] Age range bug1: max end days not correctly set for upper edge case (what is saved is the input of the user if days>31) : will not fix as removing Age Range from the web app (see comment below)
• [x] Age range bug2: end age that is less than start age is acceptable, it shouldn't ? @ielis : will not fix as removing Age Range from the web app (see comment below)
• [x] Gestational age Bug1 : edge cases not correctly set/saved (if more than 42 weeks is entered, 42 should be the value set), same for days. of more than 7 days.)
• [x] Age at last clinical encounter not saved in phenopacket: seems to be fixed in dev : saved as "timeAtLastEncounter"
• [x] Gender and alternate field are saved in the phenopacket although they are not in the UI: fixed in dev branch
• [x] max survival time should have a mix number of days: not sure, about the number, the use case in the phenopacket paper has 153 days, maybe a max number of 365 days @ielis ? fixed added in #201
• [x] Time of death: See age range bug 2: will not fix as removing Age Range from the web app (see comment below)
• [x] cause of death not correctly saved : this has been fixed in the dev branch
• [x] time element in time of death: see GestationalAge bug1: will not fix as removing Age Range from the web app (see comment below)

[ielis]

Re: age range bug 2 - Yes, I totally agree. The start must not be after the end, and I would argue that not even at the end (use Age instead). However, the implementation must take into account several issues. Suppose an element from the set {'P29D', 'P30D', 'P31D'} and P1M. Which one is greater? It depends how many days there are in a month. We may need to agree upon some heuristics.

Re: max survival time - the number of days can be complicated. The users may not have the right number all the time, e.g. for survival of 5 years 3 months and 2 days. The issue is similar to the one above - how many days are there in a month? The survival time in days can be calculated using a difference of two local dates with the first being the date of diagnosis and the second the time of death. You would need to add a small widget that has two tiny calendars, where the user selects the local dates in a similar way we search for flights (see below). Otherwise, I do not see how this can be done..

[pnrobinson]

One thing is that if somebody needs to use AgeRange it is because they need to preserve privacy. Therefore, they will not be using a Web-based app. Given the amount of other things we need to do, I think we should remove the AgeRange option from the App for now because I do not think anybody will use it in this setting!