TheJacksonLaboratory / PhenopacketLab

An Angular/Springboot web application for the loading, editing, saving of data that follows the Phenopacket Schema
BSD 3-Clause "New" or "Revised" License
7 stars 1 forks source link

Text mining: Need to be able to remove terms before approving #193

Open BethSundberg opened 1 year ago

BethSundberg commented 1 year ago

Scenario: Create a new phenopacket. Go to the phenotypic features section Use the text mining feature, get results shown below.

Image

Try to remove the term "agnosia" by clicking the "x"

click the "approve all" button.

"Agnosia" has reappeared colored in green. I expected it to be gone since this term does not apply.

Image

Remove "agnosia" again by clicking the x button.

Click on "Add approved terms"

"Agnosia" is still in the list. I expected it to be gone.

Image

Click the delete trash can icon.

complete the phenopacket.

Now it is gone. However, I should be able to remove the term in the first step, before clicking the approve all button.

belkassaby commented 1 year ago

The "approve all" button will approve all the terms found by the text mining tool. so If you rejected some terms, and then press that button it will re-approve all of the terms. the "reject all" is rejecting all of the terms found by the text mining tool. Then "add Approved terms" will add the terms approved (in green in the list) to the list of features in the phenopacket.