search

TheJacksonLaboratory / PhenopacketLab

An Angular/Springboot web application for the loading, editing, saving of data that follows the Phenopacket Schema
BSD 3-Clause "New" or "Revised" License
7 stars 1 forks source link

Deleting a feature, disease, interpretation on a phenopacket doesn't remove it #248

Closed belkassaby closed 1 year ago

belkassaby commented 1 year ago

After deleting a feature, disease interpretation from a phenopacket, closing the phenopacket tab, reopening it will show these feature, disease, interpretation previously deleted. The deletion is not working properly.

belkassaby commented 1 year ago

this bug seems to be the same for all elements of a phenopacket. (medical actions, measurements, biosamples etc)

BethSundberg commented 1 year ago

@belkassaby The deletion is now working. However, when I delete a disease it is asking me twice to confirm the deletion. It asks me once as expected. Then, when I leave that phenopacket to look at another one I get a second deletion confirmation request. It does not matter if I choose the "No" option since it is already deleted. I believe it is only disease that is doing this.

Image

belkassaby commented 1 year ago

@BethSundberg https://github.com/TheJacksonLaboratory/PhenopacketLab/pull/254 should fix this

BethSundberg commented 1 year ago

This is now working properly on the dev site.