TheJacksonLaboratory / PhenopacketLab

An Angular/Springboot web application for the loading, editing, saving of data that follows the Phenopacket Schema
BSD 3-Clause "New" or "Revised" License
7 stars 1 forks source link

Refactor stepper UI #253 #254

Closed belkassaby closed 1 year ago

belkassaby commented 1 year ago

This PR is an improvement on the way the stepper is implemented. There is a current toggle button which allows toggling/changing the profile while in the stepper. The default profile is the rare disease but clicking on the toggle will show all possible steps. We can comment out that button if need be. this is deployed on phenopacketlab-dev.jax.org

belkassaby commented 1 year ago

Also, @ielis this is a question for you: here I just added the file to the stepper UI, where I'm re-using the existing File component that can be viewed when a phenopacket has been created (the accordion element before metadata) that has an "add file" button and then enables users to create Files. I was thinking of simplifying the code base by re-using the different components of a Phenopacket (with their corresponding tables) in the place of the almost similar steps (that have tables with less details columns). here is an example of what we currently have: for diseases:

Screenshot 2023-07-22 at 8 16 31 AM

and in the stepper:

Screenshot 2023-07-22 at 8 16 56 AM

The changes I would do would make it look similar to the files where the same component is re-used

Screenshot 2023-07-22 at 8 17 49 AM Screenshot 2023-07-22 at 8 18 36 AM
BethSundberg commented 1 year ago

@belkassaby On the dev site, I can see the change in the rare disease/all steps button. This is working as expected if you start by using the "create" button. However, if you start with the "+ add phenopacket" button, it begins by showing the "show rare disease steps" button. The first time you click it there is no change to the stepper. This could be confusing. Can you make it start with the "show all available steps" button in this case. image