search

TheJacksonLaboratory / PhenopacketLab

An Angular/Springboot web application for the loading, editing, saving of data that follows the Phenopacket Schema
BSD 3-Clause "New" or "Revised" License
7 stars 1 forks source link

Sidebar buttons not working #256

Closed BethSundberg closed 1 year ago

BethSundberg commented 1 year ago

On the dev site, When I am looking at a phenotype, the sidebar buttons (both) don't do anything.

Image

If I am looking at a list of phenotypes, the "+Add phenotype" button does not do anything.

If I start up the browser, the "+Add Phenotype" button does not do anything

BethSundberg commented 1 year ago

@belkassaby The +Add Phenotype button is working now on dev.

However, when the screen is showing some phenopackets (see screen shot) the sidebar "Phenopackets" does not return the list. To get to the list you must click on the "phenopackets" link on the main screen. If you are creating a phenopacket that is not yet completed, then the "phenopackets" on the sidebar returns the list. Is this desired? I thought before the sidebar button always returned the list.

Image

iimpulse commented 1 year ago

Theres not much use currently for the sidebar. I am in favor of removing it for now.

belkassaby commented 1 year ago

I will remove in this PR https://github.com/TheJacksonLaboratory/PhenopacketLab/pull/254 before merging yeah?

BethSundberg commented 1 year ago

This problem is solved on dev by removing the sidebar