search

TheJacksonLaboratory / PhenopacketLab

An Angular/Springboot web application for the loading, editing, saving of data that follows the Phenopacket Schema
BSD 3-Clause "New" or "Revised" License
7 stars 1 forks source link

Feature/persistence #272

Closed iimpulse closed 1 year ago

iimpulse commented 1 year ago
belkassaby commented 1 year ago

@iimpulse i just committed a fix to the PR that came from my previous branch refactoring. And also added the persistence to db when uploading a file. I'm checking out a bug related to the time elements that once persisted and then retrieved from the db are not correctly displayed anymore on the front end. it might be due to returning a JSONObject instead of a string. I have to check it out more in detail.

iimpulse commented 1 year ago

Im not married to the JSONobject type. We would just need to load it back to an object in the client if we want to work with it

ielis commented 1 year ago

OK, I'll make the changes to remove the org.json et al. and push them to this PR. We can evaluate afterwards, OK?

belkassaby commented 1 year ago

I can add the commit on the frontend to turn it back into a Phenopacket using the convert method we have on the Phenopacket class

belkassaby commented 1 year ago

I have just worked on fixing afew bugs and moving most of the remote updates to DB to the phenopacketService so it is all in one place

belkassaby commented 1 year ago

I will merge this PR for you @iimpulse . So I can work on the other PR im doing (the refactoring of components location, removing all angular material and cherry on the cake : upgrade to angular 16 and primeng 16...)