TheJacksonLaboratory / PhenopacketLab

An Angular/Springboot web application for the loading, editing, saving of data that follows the Phenopacket Schema
BSD 3-Clause "New" or "Revised" License
7 stars 1 forks source link

Gestational age | days can be set to >= 7 days #273

Closed ielis closed 1 year ago

ielis commented 1 year ago

The days sub-field of Gestational age can be set to >= 7 days. However, the values must be in range 0..6 (inclusive).

image

BethSundberg commented 1 year ago

Fixed

ielis commented 1 year ago

I can still set days to 31 while it should be allow to set it to an int in range 0, 6 (inclusive) or None. Did the fix make it into SQA instance?


OK, I see it isn't possible to set the days to 31 anymore on dev. However, it can still be set to 7 but the range is 0,6 (inclusive). We're talking about completed days here and if the fetus makes it to 7 days, we increment the week and set the day to 0, to start the next gestational week.

C-1337ka commented 1 year ago

0-6 Inclusive

BethSundberg commented 1 year ago

fixed