search

TheJacksonLaboratory / PhenopacketLab

An Angular/Springboot web application for the loading, editing, saving of data that follows the Phenopacket Schema
BSD 3-Clause "New" or "Revised" License
8 stars 2 forks source link

Metadata fixes are not saved #275

Closed BethSundberg closed 1 year ago

BethSundberg commented 1 year ago

I uploaded a phenopacket that does not have the metadata in it. The validator points this out and offers to fix that issue. However, the fixes are not saved. Is that okay or should they be saved?

Image

Image

BethSundberg commented 1 year ago

See issue 277, it is the same error. There are more screen shots there.

BethSundberg commented 1 year ago

Once I closed the browser and reopened, SOME of the metadata was saved. It went from 34 errors to 9. This is using bethlem-myopathy example.

Image

It looks like all were saved, but some are not.

Image

belkassaby commented 1 year ago

Fixing #277 has fixed this issue too

BethSundberg commented 1 year ago

SQA confirms that this is fixed.