TheJacksonLaboratory / diachromatic

Diachromatic is a Java application for preprocessing and quality control of Hi-C and CHi-C data.
https://diachromatic.readthedocs.io/en/latest/
GNU General Public License v3.0
3 stars 1 forks source link

Current digest map insufficient if overhanging digest ends were filled in #77

Closed hansenp closed 9 months ago

hansenp commented 5 years ago

For the original Hi-C protocol, the overhanging digest ends are filled in.

nl_hi-c_0418_1

For the truncation step, Diachromatic takes this into account but not for the align step. Consider the following illustration.

screen shot 2019-02-06 at 7 04 11 am

With the current implementation of the digest map both reads are assigned to the digest D3.

pnrobinson commented 1 year ago

@hansenp is this issue still open?

hansenp commented 1 year ago

I don't know.

hansenp commented 1 year ago

That's a long time ago. I assume it's still open.

hansenp commented 9 months ago

This should only affect a very small number of reads and therefore only have a minor impact. Reopen if necessary.