search

TheJacksonLaboratory / vmvt

vmvt: variant-motif visualization tool
https://vmvt.readthedocs.io/en/latest/index.html
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Remove the redundant `maven-resources-plugin` declaration #37

Closed ielis closed 4 years ago

ielis commented 4 years ago

Hi @pnrobinson , I'd like to point out that specifying the maven-resource-plugin on line 60 in vmvt-cli/pom.xml is redundant. The default behavior does the same thing without adding complexity and a potential bugs to the pom.xml.

Please feel free to merge and delete the branch if you think the suggested changes are appropriate

ielis commented 4 years ago

I think if the file is present at the standard location, it should be copied into the build directory by default by this plugin. No need to specifically include the file, unless we need to e.g. perform filtering.

However, when making JAR file, we might need to specify the log4j2.xml in order to bundle the file into JAR. But that's a different plugin, isn't it?