search

TheJoeFin / Text-Grab

Use OCR in Windows quickly and easily with Text Grab. With optional background process and notifications.
https://www.microsoft.com/en-us/p/text-grab/9mznkqj7sl0b?cid=TextGrabGitHub
MIT License
3.16k stars 219 forks source link

Multiple Monitor text extraction #228

Open snarf22 opened 1 year ago

snarf22 commented 1 year ago

Describe the bug When using Fullscreen grab mode with multiple monitors of different resolutions, the higher resolution monitor appears to briefly scale to a lower resolution. This is also applicable to Text Extractor Powertoy for what its worth.

Where is the bug

To Reproduce Steps to reproduce the behavior:

  1. Initiate Fullscreen grab with multiple monitors of different resolutions
  2. See error

Expected behavior Fullscreen Grab mode does not change the appearance/zoom of my monitor, and allows me to capture everything even at differing resolutions

Where did you get Text Grab?

Screenshot screengrab

Desktop (please complete the following information):

TheJoeFin commented 1 year ago

Hello @snarf22 thank you for the issue. I rewrote the logic to launch Fullscreen Grabs. I'm going to make a release for you to test, but in the mean time can you share a screenshot of how your monitors are positioned from the Settings. I would like to better understand the X,Y coordinates of each window so I can try to replicate something similar on my test setup.

snarf22 commented 1 year ago

Thank you for the super quick response!

Hopefully this is what you're asking for. Resolution of left monitor: 2560x1440 middle monitor: 1920x1200 right monitor: 1920x1080 (off)

image

TheJoeFin commented 1 year ago

@snarf22 please download and try v3.2.0-preview1 and let me know if this issue persists.

https://github.com/TheJoeFin/Text-Grab/releases/tag/v3.2.0-preview1

snarf22 commented 1 year ago

Unfortunately it does not fix the issue. It seems like the overlayed appearance/resolution shift is related to the 3rd monitor being off -- for some more context it is a television connected through an AV receiver via HDMI. Hitting the pause button in TextGrab to freeze what is on screen fixes the zoom level, but there is still the 3rd monitor overlay appearing on "Monitor 2" which is primary. When the TV itself is on, everything works without problem. Now that I'm seeing this, I'm wondering if this is not specifically a text grab issue and more of a systemwide thing with the way windows treats on/off states and HDMI devices? Windows snipping tool manages to deal with the monitor setup without an issue though...

That's a lot of speculation but either way I appreciate your efforts here. If you would like me to record a video or otherwise provide you more information I would be happy to do so.

Thanks!

TheJoeFin commented 1 year ago

Sorry to hear it is still giving you trouble. A video would be helpful, you can email the video (or a link) to Joe@TextGrab.net

TheJoeFin commented 1 year ago

@snarf22 I have made changes to the logic which places new Full-screen Grabs in preview2. Check it out here and let me know if this fixes the issue. https://github.com/TheJoeFin/Text-Grab/releases/tag/v3.2.0-preview2

snarf22 commented 1 year ago

The resolution strangeness and the double overlayed shading no longer happens, but only the primary monitor is activated with fullscreen grab now. Would you prefer I take a video of the results with preview 1 or preview 2?

TheJoeFin commented 1 year ago

A video of preview2 would be appreciated.

dannyboy2223 commented 1 year ago

Similar issue. Worked for me before version 3.2.0. My laptop is my higher resolution (but smaller screen). My monitor is lower resolution and considered "display 2", but with it's larger size, I tend to use it as my primary monitor. Text Grab used to pop up on the laptop but allow the cursor to move over to my larger monitor (display 2). With the latest version, it only can capture text (using the simple crosshair option) on the laptop (display 1). It won't move to display 2.

TheJoeFin commented 1 year ago

@dannyboy2223 can you confirm the last version number which worked for you so I can compare.

dannyboy2223 commented 1 year ago

3.2.0

From: Joseph Finney @.> Sent: Wednesday, February 1, 2023 10:51 AM To: TheJoeFin/Text-Grab @.> Cc: dannyboy2223 @.>; Mention @.> Subject: Re: [TheJoeFin/Text-Grab] Multiple Monitor text extraction (Issue #228)

@dannyboy2223 https://github.com/dannyboy2223 can you confirm the last version number which worked for you so I can compare. — Reply to this email directly, view it on GitHub https://github.com/TheJoeFin/Text-Grab/issues/228#issuecomment-1412285488 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AFSLTUZYVYXDYZHPU66VV6TWVKA63ANCNFSM6AAAAAATPBY5BE . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AFSLTUYZW66NQDSNM6S3MALWVKA63A5CNFSM6AAAAAATPBY5BGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSUFXCDA.gif Message ID: @. @.> >

TheJoeFin commented 1 year ago

@dannyboy2223 Please send the version where Text Grab was working properly.

Also providing information about the screen layout, resolution, and scale factor will be helpful to reproduce the problem. image

Display Scale Resolution
1 125% 1920x1080
2 150% 3840x2160

This information can be found in the Windows Settings under System > Display

dannyboy2223 commented 1 year ago

Sorry, I just upgraded to current version. Not sure what my previous version was.

Display 1: Internal (laptop) Display, Intel UHD Graphics, 3840 x 2160, 60 Hz Display 2: LG Ultrawide. 2560 x 1080, 60 Hz

From: Joseph Finney @.> Sent: Wednesday, February 1, 2023 11:01 AM To: TheJoeFin/Text-Grab @.> Cc: dannyboy2223 @.>; Mention @.> Subject: Re: [TheJoeFin/Text-Grab] Multiple Monitor text extraction (Issue #228)

@dannyboy2223 https://github.com/dannyboy2223 Please send the version where Text Grab was working properly. Also providing information about the screen layout, resolution, and scale factor will be helpful to reproduce the problem. https://user-images.githubusercontent.com/7809853/216095050-c80849c3-ddde-4745-8be9-ba0b757e2869.png

Display Scale Resolution

1 125% 1920x1080

2 150% 3840x2160 This information can be found in the Windows Settings under System > Display — Reply to this email directly, view it on GitHub https://github.com/TheJoeFin/Text-Grab/issues/228#issuecomment-1412302137 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AFSLTU3H5346E7YO5VDC243WVKCCDANCNFSM6AAAAAATPBY5BE . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AFSLTU6JLSD3QYY2323XMM3WVKCCDA5CNFSM6AAAAAATPBY5BGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSUFYCTS.gif Message ID: @. @.> >

TheJoeFin commented 1 year ago

@dannyboy2223 Where are you getting Text Grab: From the Microsoft Store or GitHub releases?

Also please provide monitor scale factors and positions. Those are a crucial part of this issue.

dannyboy2223 commented 1 year ago

Sure. Primary display I use is Display 2 since it is larger. Display 1 is the laptop, and this is where Text-Grap opens.

Display 1: Internal (laptop) Display, Intel UHD Graphics, 3840 x 2160, 60 Hz, 300% zoom Display 2: LG Ultrawide. 2560 x 1080, 60 Hz, 100% zoom

From: Joseph Finney @.> Sent: Wednesday, February 1, 2023 12:37 PM To: TheJoeFin/Text-Grab @.> Cc: dannyboy2223 @.>; Mention @.> Subject: Re: [TheJoeFin/Text-Grab] Multiple Monitor text extraction (Issue #228)

@dannyboy2223 https://github.com/dannyboy2223 Where are you getting Text Grab: From the Microsoft Store or GitHub releases? Also please provide monitor scale factors and positions. Those are a crucial part of this issue. — Reply to this email directly, https://github.com/TheJoeFin/Text-Grab/issues/228#issuecomment-1412454938 view it on GitHub, or https://github.com/notifications/unsubscribe-auth/AFSLTU6TQREV2ZTQIS2PWB3WVKNKXANCNFSM6AAAAAATPBY5BE unsubscribe. You are receiving this because you were mentioned. https://github.com/notifications/beacon/AFSLTU7JX7INQTPAKMQX3ITWVKNKXA5CNFSM6AAAAAATPBY5BGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSUGBNBU.gif Message ID: < @.> @.>

dannyboy2223 commented 1 year ago

Microsoft store. Just sent the scale factors and positions, but it is display 1, at 300%, on the right. Display 2, at 100%, on the left.

Dan

From: Joseph Finney @.> Sent: Wednesday, February 1, 2023 12:36:43 PM To: TheJoeFin/Text-Grab @.> Cc: dannyboy2223 @.>; Mention @.> Subject: Re: [TheJoeFin/Text-Grab] Multiple Monitor text extraction (Issue #228)

@dannyboy2223https://github.com/dannyboy2223 Where are you getting Text Grab: From the Microsoft Store or GitHub releases?

Also please provide monitor scale factors and positions. Those are a crucial part of this issue.

— Reply to this email directly, view it on GitHubhttps://github.com/TheJoeFin/Text-Grab/issues/228#issuecomment-1412454938, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFSLTU6TQREV2ZTQIS2PWB3WVKNKXANCNFSM6AAAAAATPBY5BE. You are receiving this because you were mentioned.Message ID: @.***>

dannyboy2223 commented 1 year ago

Joe, Is there (was there) a setting that lets me click on the Text Grab program icon, which then brings up just the crosshair cursor, which I can then move over my text of interest, drag a square around it, and it then copies the text to the clipboard? This is the functionality I had in my previous version (sorry, don't know the version number). Thanks in advance.

TheJoeFin commented 1 year ago

@dannyboy2223 it sounds like you are describing the Full-Screen Grab mode of Text Grab. When you right click on the Text Grab icon on the Taskbar you can click "Full Screen" and that will allow you to select a region to OCR. If this is not the default behavior you can change that in the settings by right clicking the Taskbar icon for Text Grab and click "Settings" and choose "Full Screen" for the default launch window.

TheJoeFin commented 1 year ago

@dannyboy2223 Are you using DisplayFusion on this PC?

dannyboy2223 commented 1 year ago

Not that I know of.

From: Joseph Finney @.> Sent: Sunday, March 5, 2023 10:02 AM To: TheJoeFin/Text-Grab @.> Cc: dannyboy2223 @.>; Mention @.> Subject: Re: [TheJoeFin/Text-Grab] Multiple Monitor text extraction (Issue #228)

@dannyboy2223 https://github.com/dannyboy2223 Are you using DisplayFusion on this PC? — Reply to this email directly, view it on GitHub https://github.com/TheJoeFin/Text-Grab/issues/228#issuecomment-1455116065 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AFSLTU2KOOZUSE77RZIXHX3W2STFTANCNFSM6AAAAAATPBY5BE . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AFSLTU3BYEJUFABZO75M23LW2STFTA5CNFSM6AAAAAATPBY5BGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSWXNHSC.gif Message ID: @. @.> >

TheJoeFin commented 2 months ago

@dannyboy2223 Updates have been made to the way Text Grab places the windows in version 4.5. Have you tested the latest version?