search

TheJoshW / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
1 stars 0 forks source link

Runout doesn't trigger during print #17

Closed TheJoshW closed 3 years ago

TheJoshW commented 3 years ago

During a print runout doesn't trigger when filament runs out. Steps to reproduce: Run a print with insufficient filament and wait for it to runout. Expected behaviour: Print pauses Actual Behaviour: Print continues to completion with no filament Possible cause: Issue appeared upon incorporation of PR #3982. So could be caused by extruder position direction issue in stepper.py (https://github.com/KevinOConnor/klipper/pull/3982/files/19cd8cf48740813e8bbf037eb9282340a959a3d3), or timers not stopping/starting correctly with print start/stop.

TheJoshW commented 3 years ago

Looks like this issue may be in the extruder position code, see comments I made in PR #3982.

TheJoshW commented 3 years ago

Fixed by latest changes to PR #3982, this issue can be closed.