search

TheJuki / KFormMaster

Generic form builder in Kotlin
https://thejuki.github.io/KFormMaster/
Apache License 2.0
196 stars 46 forks source link

Setting FormButtonElement margin in FormBuilder init has no effect #286

Closed Marc-Stables closed 2 years ago

Marc-Stables commented 2 years ago

Description

Margin is not applied to buttons despite the button being provided a FormElementMargins object.

I believe this is because the formElementMainLayout element is not being provided to the BaseFormViewRenderer.baseSetup function.

I have a fix ready for this and am happy to submit a pull request.

Expected behavior

Margin should be applied to the button element.

Actual behavior

The provided FormElementMargins is ignored and margin is not applied.

Steps to reproduce the bug

  1. Set the 'margins' property of a button element when creating a new form
  2. Inspect the rendered form

KFormMaster version

TheJuki commented 2 years ago

I just released 8.3.0. Please update your dependency and let me know if this is fixed now.

TheJuki commented 2 years ago

I am closing this issue. If you have any issues feel free to reopen.