The limit and skip params are being stripped in the DirectoryInsights module in favor of auto-pagination for results. With the reintroduction of the limit param, this will allow for manually setting limits which will save time in fetching results and will also allow for more precise filtering. If no limit param is specified, the function will automatically auto-paginate as it did previously
Is there anything particularly tricky?
NA
How should this be tested?
Run Get-JcSdkEvent -Service:('all') -StartTime:((Get-date).AddDays(-7)) -Limit 1 -Sort:("DESC")
Validate that it will error stating there is no parameter Limit
Run (Get-JcSdkEvent -Service:('all') -StartTime:((Get-date).AddDays(-7)) -Sort:("DESC")).Count
Validate that events results are returned
Import the local DI psd1
Run Get-JcSdkEvent -Service:('all') -StartTime:((Get-date).AddDays(-30)) -Limit 1 -Sort:("DESC")
Validate that only 1 event is returned
Run (Get-JcSdkEvent -Service:('all') -StartTime:((Get-date).AddDays(-7)) -Sort:("DESC")).Count
Validate that the same result count is returned as step 3
Issues
What does this solve?
The limit and skip params are being stripped in the DirectoryInsights module in favor of auto-pagination for results. With the reintroduction of the limit param, this will allow for manually setting limits which will save time in fetching results and will also allow for more precise filtering. If no limit param is specified, the function will automatically auto-paginate as it did previously
Is there anything particularly tricky?
NA
How should this be tested?
Get-JcSdkEvent -Service:('all') -StartTime:((Get-date).AddDays(-7)) -Limit 1 -Sort:("DESC")
(Get-JcSdkEvent -Service:('all') -StartTime:((Get-date).AddDays(-7)) -Sort:("DESC")).Count
Get-JcSdkEvent -Service:('all') -StartTime:((Get-date).AddDays(-30)) -Limit 1 -Sort:("DESC")
(Get-JcSdkEvent -Service:('all') -StartTime:((Get-date).AddDays(-7)) -Sort:("DESC")).Count
Screenshots