TheJumpCloud / jcapi

JumpCloud's Go (golang) REST API V1 SDK
https://jumpcloud.com
Mozilla Public License 2.0
13 stars 11 forks source link

Adds commands and command results #18

Closed jamesbrown7 closed 9 years ago

jamesbrown7 commented 9 years ago

Also removes most manual marshalling and unmarshalling

bryancallahan commented 9 years ago

:+1:

ppg commented 9 years ago

With the JSON stuff working now there's an introduction of a Results struct for most of the structs to help deserialize and they're all exported; is there value to the consumer to have those exported? If not, I would make them private, or if they're only used in one location, I might even make an anonymous struct there to handle that deserialization.

ppg commented 9 years ago

:+1: two small items, but enough changes that they can be addressed later too.