TheJumpCloud / jumpcloud-ADMU

JumpCloud Active Directory Migration Utility - JCADMU
23 stars 7 forks source link

V1.6.6 #61

Closed btstevens closed 3 years ago

btstevens commented 3 years ago

Issues

What does this solve?

When running ADMU script or GUI NOT as NT Authority\System account, the ADMU tool will fail to execute the AzureAD unbind command fully.

This PR adds logic to show a dialog box in the GUI when the 'leave domain' checkbox is checked, NOT running as SYSTEM user and joined to AzureAD. If the user clicks ok, it will launch the related wiki doc in a web browser. Cancel will return to the GUI window. The leave domain checkbox will no be disabled as it is not usable.

If the system is domain bound to AD then the leave domain checkbox will work as expected.

When the Start-Migration script is passed the params, it should continue, but if the script is not run as SYSTEM and joined to AzureAD, the unbind step will be skipped and an error logged in the ADMU log.

How should this be tested?

Test on AzureAD bound system running NOT as SYSTEM Test on non AzureAD bound system to see it still leaves the domain as expected

Screenshots

image image image

image