Changes in #553 modified the command generation process. The Serial Number variable was no longer being passed into the generated command and, certificate installations would fail on devices. This addresses the issue by passing in the serial number when generating commands.
Additional tests were written to:
Validate a certificate serial number is correctly passed into generated macOS/ Windows commands
When changing certificate generation types
The subject headers of the certificate are correct
Any old .crt file is deleted for a user. i.e. users should not have more than one .crt file at any given time if the certificate generation type is changed from usernameCN to emailSAN
Is there anything particularly tricky?
How should this be tested?
No manual tests required, the functionally of the PR should be tested automatically with pester tests.
Issues
What does this solve?
Changes in #553 modified the command generation process. The Serial Number variable was no longer being passed into the generated command and, certificate installations would fail on devices. This addresses the issue by passing in the serial number when generating commands.
Additional tests were written to:
usernameCNtoemailSANIs there anything particularly tricky?
How should this be tested?
No manual tests required, the functionally of the PR should be tested automatically with pester tests.
Screenshots