search

TheKeithStewart / tour-of-the-80s

16 stars 12 forks source link

Lint warning for "source" #1

Open alejandrogomez314 opened 5 years ago

alejandrogomez314 commented 5 years ago

Thanks for making this project! Found out about it through your awesome ng-conf talk and its been very useful for me to learn more about marble testing.

My question is: when I run npm lint on the project I get the warning "source is deprecated: This is an internal implementation detail, do not use" for the following line in app.effects.spec.ts:

set stream(source: Observable<any>) {
    this.source = source;
}

Any idea on how I could implement something different to satisfy the linter? Thanks again.

TheKeithStewart commented 5 years ago

Hi, @agomez314! I'm glad that you found the talk and this project useful!

I'm not getting the linting warning that you are referring to when I run tslint. I am getting a number of other ones about training whitespaces and shadow name variables.

Have you updated tslint and/or codelyzer locally?