search

TheKevJames / puppet-homebrew

homebrew (+brewcask! +taps!) package installer and provider
https://forge.puppet.com/thekevjames/homebrew
Apache License 2.0
18 stars 44 forks source link

Homebrew-cask should error when an app cannot be found due to a missing tap #34

Closed zbentley closed 7 years ago

zbentley commented 8 years ago

If I have a manifest (with no other taps) like this or similar:

Package {
  provider => homebrew,
  install_options => [
    '--with-default-names',
  ],
}
node default {
  package { "google-chrome-beta":
    provider => "brewcask",
    install_options => [
      "--appdir=/Applications"
    ]
  }
}

Puppet runs successfully and notifies that Notice: /Stage[main]/Main/Node[default]/Package[google-chrome-beta]/ensure: created

However, the package is not installed in /Applications, ~/Applications, or the Caskroom cache dir. This is because that particular cask (at the time of this writing) is available via the caskroom/versions tap.

If that tap is missing, the install should error.

jordigg commented 8 years ago

We should try to reproduce this again and see if the new settings with the error management catches this.

TheKevJames commented 7 years ago

Hmm, I can't replicate this, but that may not necessarily imply it was fixed. @zbentley do you still have this issue with the latest version of puppet-homebrew?

zbentley commented 7 years ago

This issue no longer occurs at the latest version. Thanks for all the hard work!